Fixups based on @cantino 's comments

Glenn 'devalias' Grant vor 10 Jahren
Ursprung
Commit
1bf0e3bc62
1 geänderte Dateien mit 3 neuen Zeilen und 4 gelöschten Zeilen
  1. 3 4
      app/models/agents/twitter_user_agent.rb

+ 3 - 4
app/models/agents/twitter_user_agent.rb

@@ -66,9 +66,8 @@ module Agents
66 66
       errors.add(:base, "username is required") unless options['username'].present?
67 67
       errors.add(:base, "expected_update_period_in_days is required") unless options['expected_update_period_in_days'].present?
68 68
 
69
-      if options[:include_retweets].present? &&
70
-        !(!!options[:include_retweets] === true || !!options[:include_retweets] === false)
71
-        errors.add(:base, "include_retweets must be a boolean (true/false)")
69
+      if options[:include_retweets].present? && !%w[true false].include?(options[:include_retweets])
70
+        errors.add(:base, "include_retweets must be a boolean value string (true/false)")
72 71
       end
73 72
 
74 73
       if options[:starting_at].present?
@@ -85,7 +84,7 @@ module Agents
85 84
     end
86 85
 
87 86
     def include_retweets?
88
-      options[:include_retweets] != false
87
+      options[:include_retweets] != "false"
89 88
     end
90 89
 
91 90
     def check